Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove outdated note on IPv6 BPF masqerading being incompatible with the Host Firewall #32685

Merged
merged 1 commit into from
May 24, 2024

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented May 23, 2024

Since commits 9c1031e ("bpf: fix missing ipv6 ct entry for snated traffic") and cfed66e ("Revert "daemon: Forbid IPv6 BPF masquerading with the host firewall""), IPv6 BPF masquerading is compatible with the Host Firewall. The documentation still states the opposite, as we forgot to remove the related note. Clean it up now.

Since commits 9c1031e ("bpf: fix missing ipv6 ct entry for snated
traffic") and cfed66e ("Revert "daemon: Forbid IPv6 BPF
masquerading with the host firewall""), IPv6 BPF masquerading is
compatible with the Host Firewall. The documentation still states the
opposite, as we forgot to remove the related note. Clean it up now.

Signed-off-by: Quentin Monnet <[email protected]>
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. area/host-firewall Impacts the host firewall or the host endpoint. labels May 23, 2024
@qmonnet qmonnet requested a review from julianwiedmann May 23, 2024 10:12
@qmonnet qmonnet requested a review from a team as a code owner May 23, 2024 10:12
@qmonnet qmonnet requested a review from lambdanis May 23, 2024 10:12
@qmonnet
Copy link
Member Author

qmonnet commented May 23, 2024

/test

Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 24, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue May 24, 2024
Merged via the queue into cilium:main with commit d486a1b May 24, 2024
63 checks passed
@qmonnet qmonnet deleted the pr/hostfw-docs branch May 28, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/host-firewall Impacts the host firewall or the host endpoint. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants