ingress: Correct FromGroups rule Parsing #32231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
|
/test |
|
@learnitall / @joamaki I don't think the test failures are related, mind a review please? |
learnitall
approved these changes
May 1, 2024
This was referenced May 1, 2024
Closed
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
For now, v1.16 development continues on the |
aanm
requested review from
a team,
nebril and
squeed
and removed request for
a team and
nebril
squeed
approved these changes
May 3, 2024
|
Unfortunately, this will need a rebase. But thanks for catching this! Since this is fixing an unshipped bug, no release note is required. |
Currently fromGroups, which was added in cilium#30708, is correctly represented in the YAML but not being converted to a rule. This commit fixes that by: - Reporting that a rule requires derivation when an ingress component does, and making sure to clear ingress rules when creating that derivative. - Adding FromGroups to parseToCiliumIngressCommonRule logic - During validation make sure that fromGroups is not combined with other L3 rules. Signed-off-by: Alex Waring <[email protected]>
Alex-Waring
force-pushed
the
AWar/ingress/corrections
branch
2 times, most recently
from
47e1e85 to
c23a75e
Compare
In the previous commit and cilium#30708 the fromGroups resource was added, but testing was not covered properly. This commit validates that we are working as expected. Signed-off-by: Alex Waring <[email protected]>
Alex-Waring
force-pushed
the
AWar/ingress/corrections
branch
from
c23a75e to
36e83ae
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30708 I created a resource that translates to a K8s resource but not to an actual resource. This PR corrects that behaviour by adding in some tests and fixing when they break. You could argue I should have done this initially, you're right.
This should be backported to 1.16 so it goes out with the original PR.