Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: Replace gocheck with built-in go test #32214

Merged
merged 21 commits into from
Apr 30, 2024
Merged

agent: Replace gocheck with built-in go test #32214

merged 21 commits into from
Apr 30, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Apr 28, 2024 •
edited
Loading

Please refer to individual commits for more details, this PR is focusing on files owned by cilium/sig-agent team.

Relates: #28596

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 28, 2024
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Apr 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 28, 2024
@sayboras
Copy link
Member Author

/ci-integration

@sayboras sayboras force-pushed the pr/tammach/gocheck-sig-agent branch from 6cd5a39 to 73fa2d5 Compare April 28, 2024 23:08
@sayboras sayboras marked this pull request as ready for review April 28, 2024 23:09
@sayboras sayboras requested review from a team as code owners April 28, 2024 23:09
@sayboras sayboras requested review from ldelossa and asauber April 28, 2024 23:09
@sayboras
Copy link
Member Author

/ci-integration

@sayboras sayboras changed the title agent: Replace gocheck with built-in go test #32212 agent: Replace gocheck with built-in go test Apr 29, 2024
@sayboras
Copy link
Member Author

Build commit failure is due to timeout, I have verified locally with the below command

Successfully rebased and updated refs/heads/pr/tammach/gocheck-sig-agent.
git rebase --exec "make build -j $(nproc)" main  1366.96s user 451.15s system 1296% cpu 2:20.19 total

sayboras added 7 commits April 29, 2024 19:36
@sayboras sayboras force-pushed the pr/tammach/gocheck-sig-agent branch from 73fa2d5 to 24517dc Compare April 29, 2024 09:38
sayboras added 9 commits April 29, 2024 19:47
@sayboras
pkg/health: Replace gocheck with built-in go test
da4787c 
One extra change is to use t.Run() for subtests.

Signed-off-by: Tam Mach <[email protected]>
@sayboras
pkg/iana: Replace gocheck with built-in go test
ab4cc9d 
Signed-off-by: Tam Mach <[email protected]>
@sayboras
pkg/ipmasq: Replace gocheck with built-in go test
be84749 
Signed-off-by: Tam Mach <[email protected]>
@sayboras
pkg/math: Replace gocheck with built-in go test
002668f 
Signed-off-by: Tam Mach <[email protected]>
@sayboras
pkg/node: Replace gocheck with built-in go test
ff17251 
Signed-off-by: Tam Mach <[email protected]>
@sayboras
pkg/option: Replace gocheck with built-in go test
6333525 
Signed-off-by: Tam Mach <[email protected]>
@sayboras
pkg/pidfile: Replace gocheck with built-in go test
7a5f6d9 
Signed-off-by: Tam Mach <[email protected]>
@sayboras
pkg/revert: Replace gocheck with built-in go test
d68a327 
Signed-off-by: Tam Mach <[email protected]>
@sayboras
pkg/safetime: Replace gocheck with built-in go test
5980aa2 
Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras force-pushed the pr/tammach/gocheck-sig-agent branch from 24517dc to 0841c73 Compare April 29, 2024 09:47
@sayboras
Copy link
Member Author

/test

ldelossa
ldelossa approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of this 👍 thanks.

@sayboras sayboras added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit dba84b0 Apr 30, 2024
264 of 265 checks passed
@sayboras sayboras deleted the pr/tammach/gocheck-sig-agent branch April 30, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@asauber asauber Awaiting requested review from asauber asauber is a code owner automatically assigned from cilium/cli

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayboras @ldelossa