Add WireGuard Configurations to Automated Network Throughput Tests #32134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
learnitall
force-pushed
the
pr/learnitall/add-wg-throughput
branch
from
5fc8ae2 to
875ee07
Compare
|
Successful run: https://github.com/cilium/cilium/actions/runs/8791561641/job/24126842792?pr=32134 Artifacts can be found in the cilium-scale-results bucket. I took a look at the values and they pass a sanity check. For example, the throughput results for WireGuard's pod-to-pod TCP_STREAM test across nodes comes in higher than IPSec but lower than without transparent encryption. |
learnitall
changed the title
learnitall
changed the title
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
learnitall
added
kind/performance
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
learnitall
added
area/encryption
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
giorio94
approved these changes
May 3, 2024
brlbil
approved these changes
May 3, 2024
This commit adds WireGuard configurations to the network performance test workflow, enabling observability into WireGuard throughput and latency performance over time. Signed-off-by: Ryan Drew <[email protected]>
The network performance workflow has a step named `vars` which determines an appropriate value for an environment variable named OWNER. This environment variable is added as a label into the GKE cluster the workflow creates. This commit fixes a bug where, if the branch the workflow is ran from contained a forward-slash, cluster creation would fail, as GKE cluster labels cannot contain forward slashes. Signed-off-by: Ryan Drew <[email protected]>
learnitall
added
the
dont-merge/preview-only
learnitall
force-pushed
the
pr/learnitall/add-wg-throughput
branch
2 times, most recently
from
6a65717 to
6d96e8a
Compare
learnitall
removed
the
dont-merge/preview-only
|
/test |
learnitall
added
dont-merge/blocked
maintainer-s-little-helper
bot
added
the
ready-to-merge
I just realized I forgot about this @giorio94, sorry about that. We can wait to backport. Right now we're only running the scale tests on main, as we haven't yet configured Ariane to run the scale test on different branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the test matrix of the network throughput workflow to include WireGuard configurations. This will allow for increased visibility into the performance of WireGuard over time, allowing for us to catch regressions.