hive: Reduce hive trace logs to debug level #32033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
the
release-note/misc
|
/test |
The cilium-agent logs get spammed with this information in standard environments, but these logs are not generally useful for users to understand what's going on. The vast majority of them take microseconds to run so they don't have any meaningful impact on startup. Create a threshold to only report long-running tasks at info level, while leaving most such reporting at debug level. Signed-off-by: Joe Stringer <[email protected]>
joestringer
force-pushed
the
pr/joe/hive-log-verbosity
branch
from
5d482db to
7ca124e
Compare
|
/test |
|
CI hit #32038, not a required workflow. |
joamaki
approved these changes
Apr 18, 2024
|
Probably it makes sense to align behind the proper implementation for the library and just update this to match, so we can be sure both trees are in sync? I'll iterate in cilium/hive#2 for now. |
|
I didn't realize how far |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cilium-agent logs get spammed with this information in standard
environments, but these logs are not generally useful for users to
understand what's going on. The vast majority of them take microseconds
to run so they don't have any meaningful impact on startup.
Create a threshold to only report long-running tasks at info level,
while leaving most such reporting at debug level.
See also corresponding Hive library PR cilium/hive#2.