-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hubble/correlation: Support deny policies #31544
hubble/correlation: Support deny policies #31544
Conversation
just stopping by to say that i'm super excited about this. i'lll play around with it next week and let you know how it goes 🚀🙏 |
It seems that at some point the datapath changed under us, and some flows now carry the verdict REDIRECTED. We actually are interested in seeing these too. Co-authored-by: David Bimmler <[email protected]> Signed-off-by: David Bimmler <[email protected]> Signed-off-by: Sebastian Wicki <[email protected]>
ac7ff33
to
f2b193d
Compare
Did some local testing. Seems to work okay, given deny policy precedence (which is not always intuitive, but I have not found any discrepancies between what the policy engine does and what we correlate with) . Also extended the unit tests. |
cool! i'll try it out today. thanks sebastian! |
/test |
✅ i did a quick manual test:
then
and generate some traffic to world:
and i see:
i wasn't seeing this field yesterday because i forgot to re-compile the hubble CLI with the new protobuf definitions 👻 |
We get the endpoint ID handed to us in the flow, so let's use it to directly look up the endpoint. Co-authored-by: David Bimmler <[email protected]> Signed-off-by: David Bimmler <[email protected]> Signed-off-by: Sebastian Wicki <[email protected]>
Instead of attempting to fetch the realized policy rule labels multiple times with a less and less specific key, use the policy match type that the flow provides us with. Co-authored-by: David Bimmler <[email protected]> Signed-off-by: David Bimmler <[email protected]> Signed-off-by: Sebastian Wicki <[email protected]>
Co-authored-by: David Bimmler <[email protected]> Signed-off-by: David Bimmler <[email protected]> Signed-off-by: Sebastian Wicki <[email protected]>
Save the policies which lead to the drop of a packet in the `{Ingress,Egress}DeniedBy` field. Co-authored-by: David Bimmler <[email protected]> Signed-off-by: David Bimmler <[email protected]> Signed-off-by: Sebastian Wicki <[email protected]>
ICMP and SCTP can also be part of the policy key. For ICMP, the policy engine allows to match on the type. Signed-off-by: Sebastian Wicki <[email protected]>
f2b193d
to
04d9fea
Compare
/test |
Reviews are in, merging |
No description provided.