Skip to content

Do not snat multicast traffic.#31512

Closed
kvaster wants to merge 1 commit intocilium:mainfrom
kvaster:mcast-no-snat
Closed

Do not snat multicast traffic.#31512
kvaster wants to merge 1 commit intocilium:mainfrom
kvaster:mcast-no-snat

Conversation

@kvaster
Copy link
Contributor

@kvaster kvaster commented Mar 19, 2024

Host multicast traffic is treated as subject for SNAT and finally it breaks keepalived working on the host.

Fixes #31502

Host multicast traffic is treated as subject for SNAT and finally it breaks keepalived working on the host.

Fixes cilium#31502

Signed-off-by: Viktor Kuzmin <kvaster@gmail.com>
@kvaster kvaster requested a review from a team as a code owner March 19, 2024 19:31
@kvaster kvaster requested a review from gentoo-root March 19, 2024 19:31
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 19, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 19, 2024
@joestringer joestringer requested a review from ldelossa April 5, 2024 03:00
@ldelossa
Copy link
Contributor

ldelossa commented Apr 5, 2024

@kvaster Can you provide a quick explanation of how this SNAT breaks keepalived.

You mention 'host multicast traffic'. This traffic is assumed sourced from the host. So in the case you are fixing here, what is the source being NAT'd to which is causing a failure?

@ldelossa ldelossa added the dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. label Apr 5, 2024
@kvaster
Copy link
Contributor Author

kvaster commented Apr 8, 2024

@ldelossa , I'm closing my PR in favour of a proper fix: #31820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. kind/community-contribution This was a contribution made by a community member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VRRP traffic dropped by Cilium - CT: Unknown L4 protocol

2 participants