Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: Add CNP example for default deny #31436

Merged
merged 2 commits into from
Jun 5, 2024
Merged

ingress: Add CNP example for default deny #31436

merged 2 commits into from
Jun 5, 2024

Conversation

sayboras
Copy link
Member

Relates: #28254

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 17, 2024
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. feature/k8s-ingress labels Mar 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 17, 2024
@sayboras sayboras marked this pull request as ready for review March 18, 2024 08:01
@sayboras sayboras requested review from a team as code owners March 18, 2024 08:01
learnitall
learnitall suggested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Couple of suggestions and comments.

Documentation/network/servicemesh/default-deny-ingress-policy.rst Outdated Show resolved Hide resolved
Documentation/network/servicemesh/default-deny-ingress-policy.rst Outdated Show resolved Hide resolved
Documentation/network/servicemesh/default-deny-ingress-policy.rst Outdated Show resolved Hide resolved
Documentation/network/servicemesh/default-deny-ingress-policy.rst Show resolved Hide resolved
Documentation/network/servicemesh/external-ingress-policy.rst Outdated Show resolved Hide resolved
Documentation/network/servicemesh/external-ingress-policy.rst Outdated Show resolved Hide resolved
Documentation/network/servicemesh/external-ingress-policy.rst Outdated Show resolved Hide resolved
Documentation/network/servicemesh/external-ingress-policy.rst Outdated Show resolved Hide resolved
youngnick
youngnick approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @learnitall's changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label May 6, 2024
@youngnick youngnick mentioned this pull request May 6, 2024
Closed
2 tasks
@sayboras sayboras force-pushed the tam/ingress-docs-cnp branch 2 times, most recently from 83ad688 to 339bba6 Compare May 7, 2024 12:03
@sayboras sayboras requested a review from learnitall May 7, 2024 12:03
@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label May 8, 2024
learnitall
learnitall approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this completely went under my radar, my apologies @sayboras.

@sayboras sayboras force-pushed the tam/ingress-docs-cnp branch from 339bba6 to 339ae92 Compare June 4, 2024 08:33
sayboras added 2 commits June 5, 2024 17:13
@sayboras
docs: Lift and shift CNP page for Ingress
80e9ccd 
This is move external lockdown policy section to its own page, so that
we can have more rooms for other CNP examples.

Signed-off-by: Tam Mach <[email protected]>
@sayboras
ingress: Add CNP example for default deny
9800ce5 
Relates: cilium#28254
Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras force-pushed the tam/ingress-docs-cnp branch from 339ae92 to 9800ce5 Compare June 5, 2024 10:39
@sayboras
Copy link
Member Author

sayboras commented Jun 5, 2024

/test

@sayboras sayboras enabled auto-merge June 5, 2024 11:03
@sayboras sayboras added this pull request to the merge queue Jun 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 5, 2024
Merged via the queue into cilium:main with commit 0cbd730 Jun 5, 2024
63 of 64 checks passed
@sayboras sayboras deleted the tam/ingress-docs-cnp branch June 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@learnitall learnitall learnitall approved these changes

@youngnick youngnick youngnick approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. feature/k8s-ingress ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayboras @youngnick @learnitall