Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,bgpv1: Bootstrap BGP Control Plane troubleshooting doc #30506

Conversation

YutaroHayakawa
Copy link
Member

Bootstrap BGP Control Plane troubleshooting document with some very basic initial contents.

doc,bgpv1: Bootstrap BGP Control Plane troubleshooting doc

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 29, 2024
@YutaroHayakawa YutaroHayakawa added the release-note/misc This PR makes changes that have no direct user impact. label Jan 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 29, 2024
@YutaroHayakawa YutaroHayakawa marked this pull request as ready for review January 29, 2024 14:32
@YutaroHayakawa YutaroHayakawa requested review from a team as code owners January 29, 2024 14:32
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very helpful guide! Left just some minor wording suggestions.

@YutaroHayakawa YutaroHayakawa force-pushed the bgp-control-plane-trouble-shooting-guide branch 2 times, most recently from d0b6094 to 848bdda Compare January 30, 2024 08:35
@YutaroHayakawa
Copy link
Member Author

/test

Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! I just have some suggestions for word choice to help clarify some things, as well as some nit-picky grammar suggestions.

@YutaroHayakawa YutaroHayakawa force-pushed the bgp-control-plane-trouble-shooting-guide branch 4 times, most recently from 3d3084d to 83973f8 Compare February 2, 2024 01:48
@YutaroHayakawa
Copy link
Member Author

/test

Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the delay in following-up. Couple of last nits that I missed, but then we're looking good to merge.

@YutaroHayakawa YutaroHayakawa force-pushed the bgp-control-plane-trouble-shooting-guide branch from 1b21d69 to 533a21a Compare February 13, 2024 03:32
Bootstrap BGP Control Plane troubleshooting document with some very
basic initial contents.

Signed-off-by: Yutaro Hayakawa <[email protected]>
Co-authored-by: Rastislav Szabo <[email protected]>
Co-authored-by: Ryan Drew <[email protected]>
@YutaroHayakawa YutaroHayakawa force-pushed the bgp-control-plane-trouble-shooting-guide branch from 850af00 to 5600d46 Compare February 13, 2024 03:33
@YutaroHayakawa
Copy link
Member Author

/test

Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@YutaroHayakawa
Copy link
Member Author

Travis: #25202

@YutaroHayakawa YutaroHayakawa added this pull request to the merge queue Feb 15, 2024
Merged via the queue into cilium:main with commit cf45b90 Feb 15, 2024
59 checks passed
@YutaroHayakawa YutaroHayakawa deleted the bgp-control-plane-trouble-shooting-guide branch February 15, 2024 05:05
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants