Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/identitygc: remove unused GC.allocationCfg #30197

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

tklauser
Copy link
Member

It is unsed since commit 0f323a0 ("refactor: replace identity allocation globals"). Removing it also allows to drop SharedConfig.K8sNamespace which was only used to initialize GC.allocationCfg.k8sNamespace.

It is unsed since commit 0f323a0 ("refactor: replace identity
allocation globals"). Removing it also allows to drop
SharedConfig.K8sNamespace which was only used to initialize
GC.allocationCfg.k8sNamespace.

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Jan 11, 2024
@tklauser tklauser requested a review from a team as a code owner January 11, 2024 09:50
@tklauser tklauser requested a review from pippolo84 January 11, 2024 09:50
@tklauser
Copy link
Member Author

/test

@tklauser tklauser enabled auto-merge January 11, 2024 10:15
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@tklauser tklauser added this pull request to the merge queue Jan 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 11, 2024
Merged via the queue into main with commit 3dc3a9b Jan 11, 2024
206 checks passed
@tklauser tklauser deleted the pr/tklauser/operator-identitygc-cleanup branch January 11, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants