Skip to content

fqdn/dnsproxy: drop dependency on global EnableIPv{4,6} option #28968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Nov 3, 2023

Pass them as parameters to StartDNSProxy rather than depending on the global config.

Pass them as parameters to StartDNSProxy rather than depending on the
global config.

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser added area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact. labels Nov 3, 2023
@tklauser tklauser requested a review from mhofstetter November 3, 2023 12:53
@tklauser tklauser requested review from a team as code owners November 3, 2023 12:53
@tklauser
Copy link
Member Author

tklauser commented Nov 3, 2023

/test

Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 7, 2023
@squeed squeed merged commit 1f1886b into main Nov 7, 2023
@squeed squeed deleted the pr/tklauser/dnsproxy-ip-params branch November 7, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants