-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert and fix ip rules #25350
Revert and fix ip rules #25350
Conversation
f2739c2
to
348bba8
Compare
The endpoint's IP is not released int the function Delete, it is release in the function EndpointDeleted. This comments will confused the code reader. Signed-off-by: pengbinbin1 <[email protected]>
Update vishvananda/netlink/ so we can make use of fib rule RTA_PROTOCOL attribute. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit 53fef54. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit 368ec8e. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit ed5114d. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit dbce5f1. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit 9e62a84. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit 5fb791d. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit 0f3e989. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit 3271cb2. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit afdc51f. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit 9b5e74b. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit 2b6d5c4. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit 05593ee. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit a9cad19. Signed-off-by: Nikolay Aleksandrov <[email protected]>
Remove the IPv6-specific DeleteRuleIPv6() and add a family argument to DeleteRule so we can use the same function for both families. Signed-off-by: Nikolay Aleksandrov <[email protected]>
This reverts commit 9d60341. Signed-off-by: Nikolay Aleksandrov <[email protected]>
348bba8
to
5ae2df5
Compare
Removing release blocker 1.14 as this is already in v1.14: a63aabc |
I dropped the PR from the 1.13 backport queue for now, let's not set wrong expectations. |
Hi @nebril
Apparently, this indicates that attempts to queue this for backporting to 1.13.x are over; is that correct? If at all possible, could you please describe the concerns? (e.g., CI regressions, regression potential, community help with the backport is needed) Thank you, and have a great weekend! |
…stemd messing with them. Can be dropped on v1.14+ Upstream-PR: cilium#25350 Bug: b/339297320 Change-Id: I340da52623eb5cbc6e571c2df7a48ced80eb0a42 Reviewed-on: https://gke-internal-review.googlesource.com/c/third_party/cilium/+/1016152 Unit-Verified: Prow_Bot_V2 <[email protected]> Reviewed-by: Sugang Li <[email protected]> Lint: Lint 🤖 <[email protected]> Reviewed-by: Prow_Bot_V2 <[email protected]> Tested-by: Prow_Bot_V2 <[email protected]> Reviewed-by: Mark St. John <[email protected]>
This set is a second attempt at reverting the revert PR #24756, which was reverting #24288 and #24577
The upgrade problem mentioned in PR #24756 was due to wrongfully assuming that DeleteRule()
was handling both IPv4 and IPv6. Turns out there was a specific DeleteRuleIPv6() function
which seems unnecessary, so there is 1 additional patch prior to the last revert which changes DeleteRule() and adds
a new family argument, then removes DeleteRuleIPv6(). The problem manifested only when both IPv4 and IPv6 were
enabled due to the IPv6 rule deletion which was actually removing the IPv4 rule.
Note I have removed the "Revert revert" in the patch titles to make checkpatch happy.
The upgrade was tested as: