Jenkinsfile: fail build fast if one parallel stage fails #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off by: Ian Vernon <[email protected]>
ianvernon
force-pushed
the
failfast-jenkinsfile
branch
from
16f9a27
to
d9f13fd
Compare
ianvernon
added
pending-review
release-note/minor
ianvernon
changed the title
The VM used for Envoy builds was left running because CILIUM_USE_ENVOY was not set for `vagrant destroy` commands in the Jenkinsfile. Signed-off by: Ian Vernon <[email protected]>
ianvernon
force-pushed
the
failfast-jenkinsfile
branch
from
d9f13fd
to
007dc9d
Compare
|
To test this, I made the file https://jenkins.cilium.io/job/cilium/job/cilium/job/PR-2246/2/flowGraphTable/ |
aanm
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failFastoption totruein the Jenkinsfile so that if any stage in the build fails, all stages terminate and post-build actions are ran immediately. This will increase throughput for jobs on Jenkins.failFastdid not cause any regressions by leaving VMs up and running on Jenkins. This was occurring because there was no invocation ofvagrant destroy -fwithCILIUM_USE_ENVOY=1in the Jenkinsfile.Signed-off by: Ian Vernon [email protected]
Fixes: #2248