Support policy with EndpointSelector missing #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raybejjani
added
wip
and removed
area/CI
aanm
approved these changes
Nov 7, 2017
raybejjani
force-pushed
the
endpointselector-missing
branch
from
07f740a
to
41c04af
Compare
manalibhutiyani
approved these changes
Nov 7, 2017
tgraf
reviewed
Nov 7, 2017
tests/k8s/tests/04-bad-cnp-import.sh
Outdated
| log "importing CNP missing endpointSelector" | ||
| k8s_apply_policy kube-system create "${bad_policy_path}" | ||
|
|
||
| log "waiting 2 seconds for the policy to get to cilium-agent" |
There was a problem hiding this comment.
k8s_apply_policy will wait for the policy to be applied
There was a problem hiding this comment.
So it does! our tests also told me to not use sleep ;) so that was handy.
raybejjani
force-pushed
the
endpointselector-missing
branch
4 times, most recently
from
57c886c
to
d1919e4
Compare
tgraf
requested changes
Nov 8, 2017
tests/12-policy-import.sh
Outdated
| @@ -97,6 +97,14 @@ cat <<EOF | cilium -D policy import - | |||
| }] | |||
| EOF | |||
|
|
|||
| log "import policy with without an endpointSelector" | |||
raybejjani
force-pushed
the
endpointselector-missing
branch
10 times, most recently
from
2e29f81
to
96a8d1e
Compare
raybejjani
force-pushed
the
endpointselector-missing
branch
from
96a8d1e
to
827e2dd
Compare
|
OK. finally works. I tested to make sure the test failed without the fix. |
The agent would crash when a bad policy was imported via k8s. This is now rejected, and we have tests to make sure it doesn't happend again. Signed-off-by: Ray Bejjani <[email protected]>
raybejjani
force-pushed
the
endpointselector-missing
branch
from
96a8d1e
to
1a1bc0a
Compare
tgraf
approved these changes
Nov 9, 2017
tgraf
added
the
release-note/bug
tgraf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
If we import a CNP without an endpointSelector cilium-agent crashes.