proxy: Fill in { world | host } destination identity at egress #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graf <[email protected]>
Decoupled the consumable cache from the daemon structure Signed-off-by: Thomas Graf <[email protected]>
Fixes: #1458 Signed-off-by: Thomas Graf <[email protected]>
… identity Signed-off-by: Thomas Graf <[email protected]>
Also improves the unit test to hardcode the identity values that should never ever change again. Signed-off-by: Thomas Graf <[email protected]>
Signed-off-by: Thomas Graf <[email protected]>
tgraf
force-pushed
the
proxy-world-log
branch
from
0557a81
to
e36fc69
Compare
houndci-bot
reviewed
Sep 28, 2017
pkg/policy/identity.go
Outdated
| @@ -162,16 +172,19 @@ const ( | |||
| ID_UNKNOWN NumericIdentity = iota | |||
| ID_HOST | |||
| ID_WORLD | |||
| ID_CLUSTER | |||
There was a problem hiding this comment.
don't use ALL_CAPS in Go names; use CamelCase
houndci-bot
reviewed
Sep 28, 2017
pkg/policy/identity.go
Outdated
| ID_UNKNOWN NumericIdentity = iota | ||
| ID_HOST | ||
| ID_WORLD | ||
| IdentityUnknown NumericIdentity = iota |
There was a problem hiding this comment.
exported const IdentityUnknown should have comment (or a comment on this block) or be unexported
tgraf
force-pushed
the
proxy-world-log
branch
from
2215ca5
to
29d3e0b
Compare
aanm
reviewed
Sep 28, 2017
| // identity. The SHA is calculated if not already cached. | ||
| func (id *Identity) GetLabelsSHA256() string { | ||
| if id.LabelsSHA256 == "" { | ||
| id.LabelsSHA256 = id.Labels.SHA256Sum() |
There was a problem hiding this comment.
How can we guarantee the LabelsSHA256 is updated when in change a label in id.Labels?
There was a problem hiding this comment.
The labels of an identity never change. If the labels of an endpoint change, a new identity is created/assigned.
ianvernon
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.