Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: Fix CIDR comparison when updating routes #15263

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

brb
Copy link
Member

@brb brb commented Mar 9, 2021

Previously, the CIDR comparison didn't take into account the CIDR mask.
So, if IP didn't change, but the mask did, the comparison would have not
detected the change. The result of it was that old routes could not be
removed.

Fixes: c7a83bf ("datapath/linux: New scalable routing layer via Linux datapath implementation")
Signed-off-by: Sebastian Wicki sebastian@isovalent.com
Signed-off-by: Martynas Pumputis m@lambda.lt

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Previously, the CIDR comparison didn't take into account the CIDR mask.
So, if IP didn't change, but the mask did, the comparison would have not
detected the change. The result of it was that old routes could not be
removed.

Fixes: c7a83bf ("datapath/linux: New scalable routing layer via Linux datapath implementation")
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added kind/bug This is a bug in the Cilium logic. area/daemon Impacts operation of the Cilium daemon. release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.8 labels Mar 9, 2021
@brb brb requested review from a team and jibi March 9, 2021 10:40
@brb
Copy link
Member Author

brb commented Mar 9, 2021

test-me-please

@brb
Copy link
Member Author

brb commented Mar 9, 2021

test-runtime

@brb
Copy link
Member Author

brb commented Mar 10, 2021

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 11, 2021
@aanm
Copy link
Member

aanm commented Mar 11, 2021

@brb please write a user-facing release note

@aanm aanm merged commit 508b2de into master Mar 11, 2021
@aanm aanm deleted the pr/brb/fix-direct-route-equal branch March 11, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/daemon Impacts operation of the Cilium daemon. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants