-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install/kubernetes: remove quick-install from master branches #15250
Conversation
Since `:latest` tags are no longer available in the docker image repositories, we will remove the quick-install.yaml from the master branch. However, this will still be valid for stable branches so we will keep the GH action to still run on those branches. Signed-off-by: André Martins <[email protected]>
test-me-please |
test-1.20-4.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
These were useful as a reference 😢 |
@dghubble do you particularly need to reference the latest development versions of the quick-install? The most recent stable branch should still have these and we will continue to generate them for the supported stable releases at URLs like this: |
@aanm btw, this PR broke the quick-install link on this docs page: |
@joestringer It was sometimes nice to see exactly the PR where something changed in those files, but per release seems pretty reasonable to reference or link to. Thanks |
@dghubble another similar approach would be to look at the Helm charts readme, you can track the PRs for specific changes there in a similar way: https://github.com/cilium/cilium/blame/master/install/kubernetes/cilium/README.md |
Since
:latest
tags are no longer available in the docker imagerepositories, we will remove the quick-install.yaml from the master
branch. However, this will still be valid for stable branches so we will
keep the GH action to still run on those branches.
Signed-off-by: André Martins [email protected]