Hubble-ui now supports imagePullSecrets #15109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
reviewed
Feb 25, 2021
sayboras
added
area/helm
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
approved these changes
Feb 25, 2021
imagePullSecrets sets every other pod's containers to use the set secrets but currently not hubble-ui, this will add the same code the cilium daemonset and operators use to ensure pulling from private registries works. Signed-off-by: Dom Goodwin <[email protected]>
kaworu
reviewed
Feb 26, 2021
| {{- end }} | ||
| {{- if .Values.imagePullSecrets }} | ||
| imagePullSecrets: | ||
| {{ toYaml .Values.imagePullSecrets | indent 6 }} |
There was a problem hiding this comment.
Any reason this is formatted differently than the tolerations: L41? Shouldn't this be indented to 8 instead of 6?
There was a problem hiding this comment.
I was basing it off: https://github.com/cilium/cilium/blob/master/install/kubernetes/cilium/templates/cilium-agent-daemonset.yaml#L88
As it's an array 6 indentation is still valid but happy to change to 8 if preferred
imagePullSecrets:
- item
imagePullSecrets:
- item
There was a problem hiding this comment.
Thank you, I see that we indent imagePullSecrets inconsistently across the different Helm template, but that's outside the scope of this PR.
|
test-me-please Edit: K8s 1.20 kernel 4.9 hit #15132 |
kaworu
approved these changes
Feb 26, 2021
|
retest-1.20-4.9 |
christarazi
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to specify pull secrets for the hubble ui deployment.