docs: update dependency table to add links and download command #15055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joestringer
reviewed
Feb 22, 2021
There was a problem hiding this comment.
Hi @kaitoii11, thanks for the PR. The changes look good to me. Can you update the "Signed-off-by" to include your full name? This should be automatic if you configure it in git config --global user.name as well.
Signed-off-by: Kaito Ii <[email protected]>
kaitoii11
force-pushed
the
doc-requirement-table
branch
from
188437b to
f6435e8
Compare
aanm
approved these changes
Feb 23, 2021
joestringer
approved these changes
Feb 23, 2021
|
Smoke tests aren't passing, but the changes are unrelated to that and they pass the documentation checks. Good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the table to add a link and a command to download.
Signed-off-by: kaitoii11 [email protected]