-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: add eni option to use iam-role #14970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although my knowledge of AWS is too limited to provide a correct review on the content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think the second commit can be squashed with the first
Fixes: cilium#13270 Signed-off-by: Michael Ryan Dempsey <[email protected]>
@christarazi done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as @qmonnet
test-me-please |
test-1.19-4.19 |
test-1.20-4.9 |
Prevents helm from adding secret env in particular
AWS_DEFAULT_REGION
for AWS pod identity if using an iam-role.It seems that this prevents the eks-pod-identity-webhook from adding the entry if missing.
Fixes: #13270