-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: added --pprof flag/endpoint #14903
Conversation
Commit ece3fbc86ab9910bfc9955bdffefc6faa7f8fca8 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
ece3fbc
to
fb78f8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but this needs another commit with docs changes:
Run make -C Documentation update-cmdref
and commit doc changes made by this script.
oh right, thanks @nebril, I got the following error when I ran the command though:
do you know if I need specific tooling installed beforehand? 🤔 |
@mvisonneau you need to build Cilium binaries before running this, sorry for not mentioning that this was also unclear for me. Run #14925 will add docs for that |
Signed-off-by: Maxime VISONNEAU <[email protected]>
fb78f8e
to
6d4ffde
Compare
awesome, thanks for the guidance 🙇! I also had to |
test-gke |
I believe it could be useful to have it for the operator as well as I was looking to troubleshoot some goroutines.