Add labels to scrape cilium agent and operator metrics #14747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rics of cilium agent and cilium operator respectively Signed-off-by: Livingstone S E <[email protected]>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
test-me-please |
qmonnet
changed the title
qmonnet
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
retest-runtime |
|
retest-net-next |
nebril
approved these changes
Jan 28, 2021
|
retest-netnext |
aanm
approved these changes
Jan 30, 2021
|
Should this be backported to Cilium v1.9? |
aanm
removed
the
release-note/minor
aanm
added
needs-backport/1.9
release-note/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prometheus queries in dashboards provided as part of the cilium examples use the labels k8s_app(in cilium agent) and io_cilium_app(in cilium operator) as metric labels. But the service monitor manifests provided as part of the helm chart don't add these labels as part of scraping the metrics. As part of this PR I've added these labels to the targetLabels of the serviceMonitor manifests. Ref slack conversation