Observer to ignore unhandled debug event types #14589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 24573e70a94d0aed647a6bf06b45e6b0961ed985 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
gandro
approved these changes
Jan 12, 2021
gandro
added
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
anfernee
force-pushed
the
invalid-type
branch
from
24573e7 to
91850ba
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
glibsm
approved these changes
Jan 12, 2021
When running cilium-agent in debug mode, the cilium-agent will throw tons of logs which looks like this: ``` level=debug msg="failed to decode payload" error="can't decode following payload type: 2" ``` Type 2 means MessageTypeDebug. Similarly Type 3 MessageTypeCapture also has similar issue. They are only for debug, so ignore the them from local observer. Signed-off-by: Yongkun Gui <[email protected]>
anfernee
force-pushed
the
invalid-type
branch
from
91850ba to
626b8ed
Compare
|
updated. actually, I don't quite understand the difference between unknown event type and invalid event type. They look the same to me.. |
|
test-me-please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running cilium-agent in debug mode, the cilium-agent will throw
tons of logs which looks like this:
Type 2 means MessageTypeDebug. Similarly Type 3 MessageTypeCapture also
has similar issue. They are only for debug, so ignore the them from local observer.