Tag ENIs at creation time #14500
Merged
Tag ENIs at creation time #14500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ungureanuvladvictor
added
release-note/minor
ungureanuvladvictor
force-pushed
the
vladu/eni-tagging
branch
2 times, most recently
from
4bfb235 to
3b56ff2
Compare
|
test-me-please |
aanm
approved these changes
Dec 29, 2020
|
retest-4.9 |
christarazi
reviewed
Jan 1, 2021
|
Commit 1aa0130f5e3dd86a18668d449be5ccd3d538f911 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
AWS EC2 APIs now support tagging resources at creation time which means we can remove one extra API call. This is helpful in an environment where there are a lot of clients to the EC2 API and the server is rate-limiting. The downside with this is that now if the client does not have ec2:CreateTags IAM permissions the full ENI creation will fail with a 403 error code. Signed-off-by: Vlad Ungureanu <[email protected]>
ungureanuvladvictor
force-pushed
the
vladu/eni-tagging
branch
from
1aa0130 to
dd0b70e
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
test-me-please |
|
retest-net-next |
qmonnet
approved these changes
Jan 4, 2021
christarazi
approved these changes
Jan 4, 2021
pchaigno
added
ready-to-merge
maintainer-s-little-helper
bot
removed
the
ready-to-merge
|
CI is green and all team reviews are in, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS EC2 APIs now support tagging resources at creation time which means
we can remove one extra API call. This is helpful in an environment
where there are a lot of clients to the EC2 API and the server is
rate-limiting.
The downside with this is that now if the client does not have
ec2:CreateTags IAM permissions the full ENI creation will fail with a
403 error code.
Signed-off-by: Vlad Ungureanu [email protected]