Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DualStack kubernetes based IPv6 testing for Cilium #14461

Merged
merged 3 commits into from
Jan 5, 2021
Merged

DualStack kubernetes based IPv6 testing for Cilium #14461

merged 3 commits into from
Jan 5, 2021

Conversation

fristonio
Copy link
Member

Update K8sServiceTests to include IPv6 tests for Kubernetes running in Dual Stack mode.

@fristonio fristonio requested review from pchaigno and aanm December 20, 2020 22:54
@fristonio fristonio requested a review from a team as a code owner December 20, 2020 22:54
@fristonio fristonio requested a review from a team December 20, 2020 22:54
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 20, 2020
@fristonio fristonio requested a review from jibi December 20, 2020 22:54
@fristonio fristonio added the release-note/ci This PR makes changes to the CI. label Dec 20, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 20, 2020
@fristonio fristonio added area/CI Continuous Integration testing issue or flake dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 20, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 20, 2020
@fristonio fristonio force-pushed the pr/fristonio/dual-stack-ci branch from 1a81d18 to 3e41a2a Compare December 21, 2020 07:53
@fristonio
Copy link
Member Author

test-me-please

aanm
aanm requested changes Dec 21, 2020
View reviewed changes
test/helpers/utils.go Outdated Show resolved Hide resolved
test/k8sT/manifests/1.20/demo_ds_dualstack.yaml Outdated Show resolved Hide resolved
test/k8sT/Services.go Outdated Show resolved Hide resolved
test/k8sT/Services.go Outdated Show resolved Hide resolved
test/k8sT/Services.go Outdated Show resolved Hide resolved
test/k8sT/Services.go Outdated Show resolved Hide resolved
test/k8sT/Services.go Outdated Show resolved Hide resolved
test/k8sT/Services.go Outdated Show resolved Hide resolved
test/k8sT/Services.go Outdated Show resolved Hide resolved
test/k8sT/Services.go Outdated Show resolved Hide resolved
@fristonio fristonio force-pushed the pr/fristonio/dual-stack-ci branch from 3e41a2a to 70ce8b2 Compare December 21, 2020 14:23
@aanm aanm removed their assignment Dec 21, 2020
@fristonio
Copy link
Member Author

test-me-please

@fristonio
Copy link
Member Author

retest-gke

@fristonio
Copy link
Member Author

retest-runtime

christarazi
christarazi approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nits. Doesn't require a second review from me.

test/provision/k8s_install.sh Outdated Show resolved Hide resolved
test/k8sT/Services.go Outdated Show resolved Hide resolved
sayboras
sayboras approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor on file naming, happy to go either way 💯

test/k8sT/manifests/demo_ds_dualstack.yaml Show resolved Hide resolved
@fristonio
test: update services tests to add tests for IPv6 services
c52019b 
* This commit adds tests for IPv6 services deployed in the dualstack
  environment. DualStack is supported only for k8s versions >= 1.18

Signed-off-by: Deepesh Pathak <[email protected]>
@fristonio fristonio force-pushed the pr/fristonio/dual-stack-ci branch from 70ce8b2 to c52019b Compare January 4, 2021 07:57
@fristonio fristonio mentioned this pull request Jan 4, 2021
Closed
@fristonio
Copy link
Member Author

test-me-please

@fristonio fristonio requested a review from nebril January 4, 2021 16:07
@fristonio
Copy link
Member Author

retest-4.9

@aanm aanm merged commit 608d29d into master Jan 5, 2021
@aanm aanm deleted the pr/fristonio/dual-stack-ci branch January 5, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@sayboras sayboras sayboras approved these changes

@christarazi christarazi christarazi approved these changes

@pchaigno pchaigno Awaiting requested review from pchaigno

@jibi jibi Awaiting requested review from jibi

@nebril nebril Awaiting requested review from nebril

Assignees

@jibi jibi

@nebril nebril

@pchaigno pchaigno

@christarazi christarazi

Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fristonio @christarazi @aanm @sayboras @jibi @nebril @pchaigno