-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove xtables.lock and privileged=true from node-local-dns example #14319
Conversation
Signed-off-by: Thomas Gosteli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Before we merge, I would like to understand the testing of these changes. @Weil0ng @aditighag I couldn't find this file being used in CI, do we do integration/regression testing automatically? @ghouscht what kind of manual testing have you performed while preparing the PR? |
Probably the only use of this file is here https://docs.cilium.io/en/v1.9/gettingstarted/local-redirect-policy/#node-local-dns-cache. We're currently evaluating node-local-dns in our environment and during review I noticed that the container ran priviledged. This is not necessary since cilium handles traffic redirection (by a local redirect policy) to node-local-dns cache containers and due to that, the container does not need to write iptables rules itself (see also the This is also the setup we're currently still testing on our infrastructure and by the time of writing it works as expected. |
As discussed in slack, the node-local-dns cache container does not need the iptables xtables.lock mount and can thus be run unprivileged. This PR fixes the example deployment by removing the mount of the lock and the
privileged: true
directive.\cc @Weil0ng