Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium/cmd, vendor: use github.com/russross/blackfriday/v2 #14261

Merged
merged 1 commit into from
Dec 7, 2020
Merged

cilium/cmd, vendor: use github.com/russross/blackfriday/v2 #14261

merged 1 commit into from
Dec 7, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Dec 3, 2020

Use v2 API for cilium debuginfo which allows to drop the legacy v1 API
from vendor. The v2 module is already pulled in as an indirect
dependency.

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Dec 3, 2020
@tklauser tklauser requested review from a team as code owners December 3, 2020 18:11
@tklauser tklauser requested review from twpayne and rolinh December 3, 2020 18:11
@tklauser
Copy link
Member Author

tklauser commented Dec 3, 2020 •
edited
Loading

cilium debuginfo --output html is not used in CI, so should be enough if GitHub actions and Travis CI pass. Verified manually that the output file still looks reasonable.

twpayne
twpayne approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rolinh
rolinh reviewed Dec 4, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@tklauser
cilium/cmd, vendor: use github.com/russross/blackfriday/v2
1481f0f 
Use v2 API for cilium debuginfo which allows to drop the legacy v1 API
from vendor. The v2 module is already pulled in as an indirect
dependency.

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser force-pushed the pr/tklauser/bump-blackfriday branch from 15345f5 to 1481f0f Compare December 5, 2020 11:24
@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 7, 2020
@aanm aanm added dont-merge/blocked Another PR must be merged before this one. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. dont-merge/blocked Another PR must be merged before this one. labels Dec 7, 2020
@aanm aanm merged commit 55be895 into master Dec 7, 2020
@aanm aanm deleted the pr/tklauser/bump-blackfriday branch December 7, 2020 11:11
@tklauser tklauser mentioned this pull request Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@rolinh rolinh rolinh approved these changes

@twpayne twpayne twpayne approved these changes

Assignees

@twpayne twpayne

@rolinh rolinh

Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tklauser @twpayne @rolinh @aanm