Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: Use consistent Docker tag for dev-docker-image #14062

Merged
merged 1 commit into from
Nov 17, 2020
Merged

make: Use consistent Docker tag for dev-docker-image #14062

merged 1 commit into from
Nov 17, 2020

Conversation

pchaigno
Copy link
Member

This pull request fixes the dev-docker-image make target to tag the Docker image with the same tag as used in the subsequent docker push command given to the user.

Without this change, we get:

$ DOCKER_DEV_ACCOUNT=docker.io/pchaigno DOCKER_IMAGE_TAG=icmp-svc-fixed make dev-docker-image
[...]
Successfully built 642b63e04749
Successfully tagged pchaigno/cilium-dev:icmp-svc-fixed
docker tag docker.io/pchaigno/cilium-dev:icmp-svc-fixed docker.io/pchaigno/cilium-dev:icmp-svc-fixed
Push like this when ready:
docker push docker.io/pchaigno/cilium-dev:icmp-svc-fixed-amd64
$
$ docker push docker.io/pchaigno/cilium-dev:icmp-svc-fixed-amd64
The push refers to repository [docker.io/pchaigno/cilium-dev]
tag does not exist: pchaigno/cilium-dev:icmp-svc-fixed-amd64

@pchaigno
make: Use consistent Docker tag for dev-docker-image
709f464 
This commit fixes the dev-docker-image make target to tag the Docker
image with the same tag as used in the subsequent 'docker push' command
given to the user.

Signed-off-by: Paul Chaignon <[email protected]>
@pchaigno pchaigno added release-note/misc This PR makes changes that have no direct user impact. area/build Anything to do with the build, more general than area/CI labels Nov 17, 2020
@pchaigno pchaigno requested a review from a team as a code owner November 17, 2020 16:26
@pchaigno pchaigno requested a review from twpayne November 17, 2020 16:26
@joestringer joestringer merged commit 30923c1 into master Nov 17, 2020
@joestringer joestringer deleted the pr/pchaigno/fix-dev-docker-image-make-target-instructions branch November 17, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@twpayne twpayne Awaiting requested review from twpayne

Assignees

@twpayne twpayne

Labels
area/build Anything to do with the build, more general than area/CI release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchaigno @joestringer @twpayne