Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: make update-golang-image.sh update hubble-proto Dockerfile #14036

Merged
merged 1 commit into from
Nov 17, 2020
Merged

images: make update-golang-image.sh update hubble-proto Dockerfile #14036

merged 1 commit into from
Nov 17, 2020

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Nov 16, 2020

Before this patch, update-golang-image.sh would not update the hubble-proto Dockerfile.

@kaworu kaworu added priority/low This is considered nice to have. kind/cleanup This includes no functional changes. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Nov 16, 2020
@kaworu kaworu requested review from glibsm and tklauser November 16, 2020 10:06
@kaworu kaworu requested a review from a team as a code owner November 16, 2020 10:06
@kaworu
images: make update-golang-image.sh update hubble-proto Dockerfile
589af6c 
Before this patch, update-golang-image.sh would not update the
hubble-proto Dockerfile.

Signed-off-by: Alexandre Perrin <[email protected]>
@kaworu kaworu self-assigned this Nov 16, 2020
tklauser
tklauser approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kaworu kaworu added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 17, 2020
@kaworu
Copy link
Member Author

kaworu commented Nov 17, 2020

No need for a full CI run, marking as ready-to-merge.

@aanm aanm merged commit 7fc29b2 into master Nov 17, 2020
@aanm aanm deleted the pr/kaworu/fix-update-golang-image branch November 17, 2020 17:24
@tklauser tklauser mentioned this pull request Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@glibsm glibsm Awaiting requested review from glibsm

Assignees

@kaworu kaworu

@glibsm glibsm

@tklauser tklauser

Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/cleanup This includes no functional changes. priority/low This is considered nice to have. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaworu @tklauser @glibsm @aanm