Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api/hubble: Explicitly mark unused fields as reserved #13809

Merged
merged 1 commit into from
Nov 12, 2020
Merged

api/hubble: Explicitly mark unused fields as reserved #13809

merged 1 commit into from
Nov 12, 2020

Conversation

gandro
Copy link
Member

@gandro gandro commented Oct 29, 2020

All of these fields were used in older versions of the Hubble API. To
avoid accidental re-use, this commit explicitly mark these fields as
reserved.

@gandro gandro added priority/low This is considered nice to have. kind/cleanup This includes no functional changes. dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay labels Oct 29, 2020
@gandro gandro requested a review from a team as a code owner October 29, 2020 16:59
@gandro gandro requested review from a team and ti-mo October 29, 2020 16:59
@gandro gandro requested a review from glibsm October 29, 2020 16:59
rolinh
rolinh approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

michi-covalent
michi-covalent approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

glibsm
glibsm approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@glibsm glibsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool. TIL.

ti-mo
ti-mo approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about why these are unused, but the change looks sound. 👍

@aanm aanm removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Nov 10, 2020
@aanm
Copy link
Member

aanm commented Nov 11, 2020

test-me-please

@gandro
api/hubble: Explicitly mark unused fields as reserved
3d19d64 
All of these fields were used in older versions of the Hubble API. To
avoid accidental re-use, this commit explicitly mark these fields as
reserved.

Signed-off-by: Sebastian Wicki <[email protected]>
@gandro gandro force-pushed the pr/gandro/hubble-api-reserve-unused branch from bbd0846 to 3d19d64 Compare November 12, 2020 10:49
@gandro
Copy link
Member Author

gandro commented Nov 12, 2020

Rebased on master to avoid issues in CI due to the container registry rate limitting.

@gandro
Copy link
Member Author

gandro commented Nov 12, 2020

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 12, 2020
@christarazi christarazi merged commit 2df0d9d into master Nov 12, 2020
@christarazi christarazi deleted the pr/gandro/hubble-api-reserve-unused branch November 12, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michi-covalent michi-covalent michi-covalent approved these changes

@ti-mo ti-mo ti-mo approved these changes

@rolinh rolinh rolinh approved these changes

@glibsm glibsm glibsm approved these changes

@kaworu kaworu kaworu approved these changes

Assignees

@glibsm glibsm

@ti-mo ti-mo

Labels
kind/cleanup This includes no functional changes. priority/low This is considered nice to have. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gandro @aanm @kaworu @glibsm @rolinh @ti-mo @michi-covalent @christarazi