Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Point GKE doc to the cluster name var #11590

Merged
merged 1 commit into from
May 18, 2020
Merged

docs: Point GKE doc to the cluster name var #11590

merged 1 commit into from
May 18, 2020

Conversation

glibsm
Copy link
Member

@glibsm glibsm commented May 18, 2020

It's created a few lines above

@glibsm
docs: Point GKE doc to the cluster name var
21d8944 
It's created a few lines above

Signed-off-by: Glib Smaga <[email protected]>
@glibsm glibsm requested a review from a team as a code owner May 18, 2020 19:21
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@glibsm glibsm added the release-note/misc This PR makes changes that have no direct user impact. label May 18, 2020
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 18, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 37.011% when pulling 21d8944 on pr/glibsm/doc-fix into 7e328b1 on master.

michi-covalent
michi-covalent approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll miss tgraf-test.

@joestringer joestringer merged commit 13bcf96 into master May 18, 2020
@joestringer joestringer deleted the pr/glibsm/doc-fix branch May 18, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michi-covalent michi-covalent michi-covalent approved these changes

@pchaigno pchaigno pchaigno approved these changes

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glibsm @coveralls @joestringer @pchaigno @michi-covalent