test: Remove duplicate test cases from K8sServicesTest #11523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes two test cases ("TC + DR + {DSR,SNAT}") as they
duplicated by the tests in "Tests with direct routing".
Signed-off-by: Martynas Pumputis <[email protected]>
brb
added
area/CI-improvement
|
test-me-please |
brb
changed the title
|
retest-net-next |
borkmann
approved these changes
May 14, 2020
nebril
approved these changes
May 14, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
joestringer
reviewed
May 14, 2020
| @@ -1252,6 +1253,7 @@ var _ = Describe("K8sServicesTest", func() { | |||
| }) | |||
|
|
|||
| testDSR(64001) | |||
| testNodePort(true, false, false) // no need to test from outside, as testDSR did it | |||
There was a problem hiding this comment.
The previous tests also cleared the CT tables on the node after testNodePort(), is that handled here somehow or not necessary?
There was a problem hiding this comment.
As far as I can see, it's not necessary. I haven't seen a failure due to potentially stale CT entries.
There was a problem hiding this comment.
Good enough for me, we can keep an eye out in case this concern is warranted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes two test cases ("TC + DR + {DSR,SNAT}") as they are duplicated by the tests in "Tests with direct routing".