cilium: improve host-port generated service names #11469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkmann
added
pending-review
area/daemon
|
test-me-please |
gandro
approved these changes
May 11, 2020
The service-name and namespace annotation does not have to be unique and
are mainly used by hubble [0]. However, lets improve the Cilium internal
naming scheme a bit into <pod-name>/host-port/<exposed-host-port>, so the
result looks as:
# ./cilium/cilium service list -o json
[...]
"flags": {
"name": "my-nginx-78cd9b665d-xmwp8/host-port/8080",
"namespace": "default",
"trafficPolicy": "Cluster",
"type": "HostPort"
},
[...]
In any case, we can also _guarantee_ that we are never going to clash with
a regular service name since in k8s a service cannot be named this way:
# kubectl expose deployment my-nginx --type=NodePort --port=30000 --name="my-nginx-78cd9b665d-xmwp8/host-port/8080"
The Service "my-nginx-78cd9b665d-xmwp8/host-port/8080" is invalid: metadata.name: Invalid value: "my-nginx-78cd9b665d-xmwp8/host-port/8080": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')
The fact that we reuse our main BPF service handling internally is an
implementation detail - HostPort services are not accessible through DNS
this way anyway.
[0] a2c49a5
Closes: #11324
Signed-off-by: Daniel Borkmann <[email protected]>
borkmann
force-pushed
the
pr/fix-host-port-naming
branch
from
e9178ad to
9033d27
Compare
|
test-me-please |
tgraf
approved these changes
May 11, 2020
aanm
approved these changes
May 11, 2020
|
restart-ginkgo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msg.
Closes: #11324