docs: Fix "make render-docs" permissions issue #10922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of docker, when passed the `--volume` flag, will create
the directory *as root* before launching the container, which caused
`make render-docs` to fail with a permissions issue like the following:
Exception occurred:
File "/usr/local/lib/python3.7/os.py", line 221, in makedirs
mkdir(name, mode)
PermissionError: [Errno 13] Permission denied: '/src/Documentation/_build/doctrees'
Fix it by creating the directory as the current user first.
Fixes: cilium#10869
Signed-off-by: Joe Stringer <[email protected]>
joestringer
added
pending-review
area/documentation
aanm
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of docker, when passed the
--volumeflag, will createthe directory as root before launching the container, which caused
make render-docsto fail with a permissions issue like the following:Exception occurred:
File "/usr/local/lib/python3.7/os.py", line 221, in makedirs
mkdir(name, mode)
PermissionError: [Errno 13] Permission denied: '/src/Documentation/_build/doctrees'
Fix it by creating the directory as the current user first.
Fixes: #10869