Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api, daemon: drop unnecessary dependency on github.com/go-openapi/runtime/flagext #10905

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Apr 8, 2020

Same case as for commit e63a1d4 ("api, daemon: drop unused
dependency on github.com/jessevdk/go-flags"), PR #10890.

The package is pulled in because the swagger server template uses it by
default. However, we don't use any of the features of this package,
thus drop it.

…time/flagext

Same case as for commit e63a1d4 ("api, daemon: drop unused
dependency on github.com/jessevdk/go-flags"), PR #10890.

The package is pulled in because the swagger server template uses it by
default.  However, we don't use any of the features of this package,
thus drop it.

Signed-off-by: Tobias Klauser <[email protected]>s
@tklauser tklauser added pending-review kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Apr 8, 2020
@tklauser tklauser requested review from a team as code owners April 8, 2020 22:52
@tklauser
Copy link
Member Author

tklauser commented Apr 8, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 46.938% when pulling ac73595 on pr/tklauser/drop-dep-bytesize into dcbdb1e on master.

@aanm aanm merged commit 987fd7c into master Apr 9, 2020
@aanm aanm deleted the pr/tklauser/drop-dep-bytesize branch April 9, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants