monitor: Move PolicyMatchType into pkg/monitor/api #10893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is used by external components. Move it into pkg/monitor/api to reduce additional dependencies being pulled in. Signed-off-by: Thomas Graf <[email protected]>
tgraf
added
the
release-note/misc
|
test-me-please |
gandro
approved these changes
Apr 8, 2020
glibsm
reviewed
Apr 8, 2020
| PolicyEgress = 2 | ||
|
|
||
| // PolicyMatchNone is the value of MatchType indicatating no policy match | ||
| PolicyMatchNone = 0 |
There was a problem hiding this comment.
is this meant to be of type PolicyMatchType and have iota?
There was a problem hiding this comment.
Our policy is not to fix code while moving it to assist in reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type is used by external components. Move it into pkg/monitor/api
to reduce additional dependencies being pulled in.