Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: Refactor identity resolution on bpf_netdev egress #10776

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

pchaigno
Copy link
Member

See commit messages.

@pchaigno pchaigno added wip kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Mar 31, 2020
@coveralls
Copy link

coveralls commented Mar 31, 2020

Coverage Status

Coverage decreased (-0.02%) to 45.498% when pulling 3d2dbab on pr/pchaigno/refactor-netdev-egress-identity into d933cfe on master.

@pchaigno pchaigno marked this pull request as ready for review March 31, 2020 11:54
@pchaigno pchaigno requested a review from a team March 31, 2020 11:54
FIXED_SRC_SECCTX is set when FROM_HOST is set, in which case the
security ID is HOST_ID.

Signed-off-by: Paul Chaignon <[email protected]>
Regroup all identity resolution code for egress (finalize_sec_ctx(),
derive_ipv4_sec_ctx(), ipcache lookup, and FROM_HOST-deduced) in a single
function and remove unused code. Also rename identity variables to
clarify origin.

Signed-off-by: Paul Chaignon <[email protected]>
@pchaigno pchaigno force-pushed the pr/pchaigno/refactor-netdev-egress-identity branch from f4969ee to 3d2dbab Compare March 31, 2020 12:35
@pchaigno
Copy link
Member Author

test-me-please

@pchaigno
Copy link
Member Author

restart-ginkgo

@aanm aanm merged commit 560cf53 into master Apr 1, 2020
@aanm aanm deleted the pr/pchaigno/refactor-netdev-egress-identity branch April 1, 2020 09:27
pchaigno added a commit that referenced this pull request Apr 3, 2020
I reversed the ENABLE_EXTRA_HOST_DEV condition in #10776 by error
because I had initially removed it, thinking it wasn't required anymore.

Signed-off-by: Paul Chaignon <[email protected]>
tgraf pushed a commit that referenced this pull request Apr 6, 2020
I reversed the ENABLE_EXTRA_HOST_DEV condition in #10776 by error
because I had initially removed it, thinking it wasn't required anymore.

Signed-off-by: Paul Chaignon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants