Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/mac: small cleanups in MAC address parsing #10719

Merged
merged 2 commits into from
Mar 27, 2020
Merged

pkg/mac: small cleanups in MAC address parsing #10719

merged 2 commits into from
Mar 27, 2020

Conversation

tklauser
Copy link
Member

  • remove unused lxcmap.ParseMAC
  • in pkg/mac don't allocate empty MAC in case of errors

@tklauser tklauser requested a review from a team March 26, 2020 15:26
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Mar 26, 2020
@tklauser
Copy link
Member Author

test-me-please

@coveralls
Copy link

coveralls commented Mar 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 45.575% when pulling 0d6105c on pr/tklauser/mac-cleanups into 5ff7c51 on master.

@tklauser tklauser added the kind/cleanup This includes no functional changes. label Mar 26, 2020
tklauser added 2 commits March 27, 2020 00:15
@tklauser
mac: don't allocate empty MAC in case of errors
92b9096 
All callers check err before accessing the returned MAC, thus it's safe
to return nil.

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser
maps/lxcmap: remove unused ParseMAC
0d6105c 
Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser force-pushed the pr/tklauser/mac-cleanups branch from d47f846 to 0d6105c Compare March 26, 2020 23:15
@tklauser
Copy link
Member Author

test-me-please

@borkmann borkmann merged commit fed4deb into master Mar 27, 2020
@borkmann borkmann deleted the pr/tklauser/mac-cleanups branch March 27, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tklauser @coveralls @pchaigno @borkmann