Enable -Wextra when compiling bpf programs
#10596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following warning/error when compiling with -Wextra enabled:
lib/eps.h:65:43: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers]
.lpm_key = { IPCACHE_PREFIX_LEN(prefix) },
^
lib/eps.h:79:43: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers]
.lpm_key = { IPCACHE_PREFIX_LEN(prefix) },
Signed-off-by: Tobias Klauser <[email protected]>
Fix the following warnings by casting ifindex:
include/bpf/ctx/xdp.h:203:14: error: comparison of integers of different signs: 'int' and '__u32' (aka 'unsigned int') [-Werror,-Wsign-compare]
if (ifindex != ctx->ingress_ifindex)
~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Tobias Klauser <[email protected]>
tklauser
added
pending-review
sig/datapath
|
test-me-please |
joestringer
approved these changes
Mar 16, 2020
borkmann
approved these changes
Mar 16, 2020
tklauser
force-pushed
the
pr/tklauser/bpf-extra-warnings
branch
from
02e0b0b to
e5cd245
Compare
|
test-me-please |
This allows to enable extra warnings/errors with -Wextra when compiling bpf programs. Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/tklauser/bpf-extra-warnings
branch
from
e5cd245 to
103f961
Compare
|
test-me-please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
-Wextraby default and fix all warnings/errors emitted by it. This should help to catch potentially unused variables and parameters (various-Wunused*warnings) in the future, among others.This change is