test: Fix configuring the Cilium agent in dev VM #10578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helpers file was assuming that the test path is mounted into the
target VM at the location "/vagrant", but this is not the case for the
developer VM so if you attempt to run the ginkgo runtime CI against the
dev VM you'll hit this error:
Expected
<*errors.errorString | 0xc0004b0900>: {
s: "cp: cannot stat '/vagrant/cilium': No such file or directory\n",
}
to be nil
Signed-off-by: Joe Stringer <[email protected]>
|
test-me-please EDIT: Provisioning failure: |
|
test-me-please |
|
Runtime tests pass, and these changes only affect runtime tests. Ready to review. |
joestringer
changed the title
|
test-me-please |
tgraf
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helpers file was assuming that the test path is mounted into the
target VM at the location "/vagrant", but this is not the case for the
developer VM so if you attempt to run the ginkgo runtime CI against the
dev VM you'll hit this error:
This change is