Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix some minor microk8s integration issues #10577

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Mar 13, 2020

  • The runtime integration is not necessary any more since v1.7, and in
    fact causes problems trying to deploy Cilium properly to microk8s.
  • The coredns deployment in the CI tree assumes that you can fall back
    to /etc/resolv.conf, but in microk8s environments the resolv.conf will
    use coredns to resolve k8s DNS names, so this causes a loop which
    triggers havoc. Instead of deploying coredns, just assume that coredns
    is already deployed. The check for coredns later on will timeout if
    this is not true. At some point we may need to patch up the microk8s
    coredns config for cilium test domains, but I'm deferring that for
    now since it's not required for minimal CI deployment in microk8s.

This change is Reviewable

* The runtime integration is not necessary any more since v1.7, and in
  fact causes problems trying to deploy Cilium properly to microk8s.
* The coredns deployment in the CI tree assumes that you can fall back
  to /etc/resolv.conf, but in microk8s environments the resolv.conf will
  use coredns to resolve k8s DNS names, so this causes a loop which
  triggers havoc. Instead of deploying coredns, just assume that coredns
  is already deployed. The check for coredns later on will timeout if
  this is not true. At some point we may need to patch up the microk8s
  coredns config for cilium test domains, but I'm deferring that for
  now since it's not required for minimal CI deployment in microk8s.

Signed-off-by: Joe Stringer <[email protected]>
@joestringer joestringer added pending-review release-note/ci This PR makes changes to the CI. labels Mar 13, 2020
@joestringer joestringer requested a review from a team as a code owner March 13, 2020 18:21
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 45.661% when pulling 368e069 on joestringer:submit/microk8s-ci-fixes into cbd90bd on cilium:master.

@joestringer joestringer merged commit 7e145cf into cilium:master Mar 17, 2020
@joestringer joestringer deleted the submit/microk8s-ci-fixes branch March 18, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants