Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cni: fix interface sandbox in cmdAdd return value #10482

Merged
merged 1 commit into from
Mar 5, 2020
Merged

cni: fix interface sandbox in cmdAdd return value #10482

merged 1 commit into from
Mar 5, 2020

Conversation

jaffcheng
Copy link
Contributor

@jaffcheng jaffcheng commented Mar 5, 2020 •
edited by tgraf
Loading

args.Netns is the absolute path of sandbox netns, just use it as is.

Signed-off-by: Jaff Cheng [email protected]

This change is Reviewable

@jaffcheng
cni: fix interface sandbox in cmdAdd return value
4ae01b7 
args.Netns is the absolute path of sandbox netns, just use it as is.

Signed-off-by: Jaff Cheng <[email protected]>
@jaffcheng jaffcheng requested a review from a team March 5, 2020 12:12
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 45.622% when pulling 4ae01b7 on ctripcloud:pr/jaffcheng/fix-cni-return-interface-sandbox into b3b29b3 on cilium:master.

@aanm aanm added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Mar 5, 2020
@aanm
Copy link
Member

aanm commented Mar 5, 2020

test-me-please

aanm
aanm approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. How did you find it?

@tgraf tgraf added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels Mar 5, 2020
@tgraf tgraf merged commit c832368 into cilium:master Mar 5, 2020
@jaffcheng jaffcheng deleted the pr/jaffcheng/fix-cni-return-interface-sandbox branch March 6, 2020 12:11
@jaffcheng
Copy link
Contributor Author

I was trying to enforce bandwidth limit on pods and I tried Cilium -> bandwidth CNI chaining, then I found this issue.
BTW, it seems Cilium -> bandwidth chaining won't work because they both creates a qdisc on host end veth. Is there a known way to implement bandwidth limit or QoS on cilium pods? @aanm @tgraf

@gandro gandro mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadorovsky vadorovsky vadorovsky approved these changes

@aanm aanm aanm approved these changes

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jaffcheng @coveralls @aanm @tgraf @vadorovsky @gandro