Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/bpf: remove outdated godoc for UpdateElementFromPointers #10403

Merged
merged 1 commit into from
Mar 2, 2020
Merged

pkg/bpf: remove outdated godoc for UpdateElementFromPointers #10403

merged 1 commit into from
Mar 2, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Mar 2, 2020 •
edited by tgraf
Loading

Commit 55276ee ("pkg/bpf: add newer LookupElement, GetNextKey and
UpdateElement functions") added UpdateElementFromPointers but seemd to
have copied the godoc from UpdateElement. However,
UpdateElementFromPointers does not have a flags argument so adjust its
godoc comment.

This change is Reviewable

@tklauser
pkg/bpf: remove outdated godoc for UpdateElementFromPointers
f7a98bf 
Commit 55276ee ("pkg/bpf: add newer LookupElement, GetNextKey and
UpdateElement functions") added UpdateElementFromPointers but seemd to
have copied the godoc from UpdateElement. However,
UpdateElementFromPointers does not have a flags argument so adjust its
godoc comment.

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Mar 2, 2020
@tklauser tklauser requested review from aanm and a team March 2, 2020 10:38
qmonnet
qmonnet approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flags are probably passed through the struct pointed by structPtr, but I agree the documentation snippet seems useless here. Looks good to me!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 45.663% when pulling f7a98bf on pr/tklauser/pkg-bpf-cleanup into b68af48 on master.

@joestringer joestringer merged commit e59ed75 into master Mar 2, 2020
@joestringer joestringer deleted the pr/tklauser/pkg-bpf-cleanup branch March 2, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadorovsky vadorovsky vadorovsky approved these changes

@qmonnet qmonnet qmonnet approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tklauser @coveralls @aanm @qmonnet @vadorovsky @joestringer