test: bpf: Fix check for xdp support in ip #10198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ip's help output wasn't updated when support for xdpgeneric was added, so grep xdpgeneric on ip help doesn't return anything and XDP programs are never loaded. In addition, because we set pipefail and ip link set help returns a non-0 error code, the piped command always returns a non-0 error code anyway. This patch fixes both issues by using the output of the 'set dev xdpgeneric off' command directly to determine if ip supports xdpgeneric. Signed-off-by: Paul Chaignon <[email protected]>
pchaigno
added
pending-review
area/CI
pchaigno
added
area/misc
|
test-me-please |
qmonnet
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ip's help output wasn't updated when support for xdpgeneric was added, so grep xdpgeneric on ip help doesn't return anything and XDP programs are never loaded. In addition, because we set pipefail and
ip link set helpreturns a non-0 error code, the piped command always returns a non-0error code anyway.
This PR fixes both issues by using the output of the
set dev xdpgeneric offcommand directly to determine if ip supports xdpgeneric.This change is