Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clustermesh: Add cilium status section #10169

Merged
merged 1 commit into from
Feb 14, 2020
Merged

clustermesh: Add cilium status section #10169

merged 1 commit into from
Feb 14, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Feb 12, 2020 •
edited
Loading

Brief status:

ClusterMesh:            1/1 clusters ready, 1 global-services

Verbose status:

ClusterMesh:            1/1 clusters ready, 1 global-services
   cluster2: ready, 2 nodes, 3 identities, 1 services
   └  etcd: 1/1 connected, lease-ID=19b870354bdf4432, lock lease-ID=19b870354bdf4434, has-quorum=true: https://cluster2.mesh.cilium.io:2379 - 3.3.12

This change is Reviewable

@tgraf
clustermesh: Add cilium status section
f8c029a 
Brief status:
```
ClusterMesh:            1/1 clusters ready, 1 global-services
```

Verbose status:
```
ClusterMesh:            1/1 clusters ready, 1 global-services
   cluster2: ready, 2 nodes, 3 identities, 1 services
   └  etcd: 1/1 connected, lease-ID=19b870354bdf4432, lock lease-ID=19b870354bdf4434, has-quorum=true: https://cluster2.mesh.cilium.io:2379 - 3.3.12
```

Signed-off-by: Thomas Graf <[email protected]>
@tgraf tgraf added kind/enhancement This would improve or streamline existing functionality. pending-review release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Feb 12, 2020
@tgraf tgraf requested a review from a team February 12, 2020 23:01
@tgraf tgraf requested review from a team as code owners February 12, 2020 23:01
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 44.533% when pulling f8c029a on pr/tgraf/clustermesh-status into f5c42e7 on master.

@tgraf
Copy link
Member Author

tgraf commented Feb 12, 2020

test-me-please

joestringer
joestringer approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my codeowners. I didn't look beyond those parts, but can do if you need a more thorough review.

@aanm
Copy link
Member

aanm commented Feb 13, 2020

@tgraf I thought this would need backport to 1.7?

@tgraf
Copy link
Member Author

tgraf commented Feb 13, 2020

I'm OK with that but it's definitely not a bugfix so it would be a feature backport.

@joestringer
Copy link
Member

Given the outstanding clustermesh bug and the fact that this was written to help debug it, I would be in favour of backporting for v1.7 to help debuggability.

@aanm aanm merged commit 1bf235a into master Feb 14, 2020
@aanm aanm deleted the pr/tgraf/clustermesh-status branch February 14, 2020 10:37
@nebril nebril mentioned this pull request Feb 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
kind/enhancement This would improve or streamline existing functionality. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tgraf @coveralls @aanm @joestringer @borkmann @nebril