Remove unused funcs, types and global vars #10085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
force-pushed
the
pr/tklauser/binsize-reduce-unused
branch
from
228aa37 to
cc3fd11
Compare
|
Release note label not set, please set the appropriate release note. |
tklauser
added
release-note/misc
|
test-me-please |
tklauser
force-pushed
the
pr/tklauser/binsize-reduce-unused
branch
from
cc3fd11 to
db75818
Compare
|
test-me-please |
aanm
added
the
dont-merge/wait-until-release
joestringer
approved these changes
Feb 7, 2020
| clientPkg "github.com/cilium/cilium/pkg/client" | ||
| healthClientPkg "github.com/cilium/cilium/pkg/health/client" | ||
|
|
||
| "github.com/prometheus/client_golang/prometheus" | ||
| log "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| const ( | ||
| updateLatencyMetricsInterval = 30 * time.Second |
There was a problem hiding this comment.
Seems that the const has not been used since the beginning: #4437 (also git log -S updateLatencyMetricsInterval).
brb
approved these changes
Feb 10, 2020
aanm
removed
the
dont-merge/wait-until-release
|
@tklauser needs rebase |
aanm
approved these changes
Feb 18, 2020
aanm
added
the
dont-merge/needs-rebase
tklauser
force-pushed
the
pr/tklauser/binsize-reduce-unused
branch
from
db75818 to
6173a27
Compare
tklauser
removed
the
dont-merge/needs-rebase
|
test-me-please |
1 similar comment
|
test-me-please |
The `log` var is unused in some packages, so remove it where this is the case. Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
This is unused since commit 1121202 ("fqdn: L3-aware L7 DNS policy enforcement") Signed-off-by: Tobias Klauser <[email protected]>
Also reorder initialization in NewDatapath so that embedded types are initialized first. Signed-off-by: Tobias Klauser <[email protected]>
(*linuxNodeHandler).lookupDirectRoute is only used in test code and does not use any members of linuxNodeHandler, so make it a regular function and move it to node_linux_test.go Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
type EndpointPolicyVisibilityEventResult, (*Endpoint).getIDandLabels and (*Endpoint).removeProxyRedirect are unused, remove them. Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
Remove unused type rulesManager and func checkLocks. Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/tklauser/binsize-reduce-unused
branch
from
6173a27 to
da72060
Compare
|
test-me-please |
1 similar comment
|
test-me-please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unused funcs, types and global vars all over the place, found by running
staticcheck -check U1000.before:
after:
No big wins here for #10056 yet.
This change is