Remove the repo lock workflow #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Michi Mutsuzaki <[email protected]>
cilium/cilium#34178 got merged. Remove the lock workflow and update CONTRIBUTING.md. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/unlock
branch
from
f0a817d to
bfcc82d
Compare
|
@michi-covalent was the intention of this PR? |
no we are keeping cilium-cli repo. see https://github.com/cilium/design-cfps/blob/main/cilium/CFP-25694-move-cilium-cli-to-cilium-repo.md?plain=1#L77-L90 |
michi-covalent
requested review from
a team and
tklauser
and removed request for
a team
viktor-kurchenko
approved these changes
Aug 17, 2024
marseel
approved these changes
Aug 19, 2024
asauber
approved these changes
Aug 19, 2024
|
Is the actual source code of cilium CLI in another repo now? It would be nice to have this mentioned in README. |
|
yes it's in cilium/cilium repo. it's documented in CONTRIBUTING.md: https://github.com/cilium/cilium-cli/blob/main/CONTRIBUTING.md#contribution-workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cilium/cilium#34178 got merged. vendor cilium-cli from cilium/cilium repo.
4 commits: