-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #2698
Update CONTRIBUTING.md #2698
Conversation
d285579
to
a56aabf
Compare
a56aabf
to
6a7f32b
Compare
cc @joestringer @aanm (i can't seem to @ cilium-maintainers team) |
@cilium/cilium-maintainers |
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intent to change the user experience for this too? For instance, expect users to download from cilium/cilium, release on a different cadence?
the current proposal is to not change the user experience, at least in the short term. we'll continue to publish release artifacts in cilium/cilium-cli repo at its own release cadence independent of cilium/cilium release cycle: |
OK, the reason I ask is that this is placing the warning right at the top as the first thing that users see. This looks like a warning for users to get ready to change the way they pull the tool. Developer-focused warnings should probably be lower down in the readme in a section that's clearly about how you contribute. |
yeah makes sense. maybe i can update https://github.com/cilium/cilium-cli/blob/main/CONTRIBUTING.md instead 💭 |
Is it expected that cilium/cli is also an owner for the README? That doesn't make much sense for me. |
cilium/cli team is the default owner of this repo, so yeah i guess it is sort of expected https://github.com/cilium/cilium-cli/blob/main/CODEOWNERS#L17 do you have any particular team on your mind who should own README.md? |
cilium-cli-maintainers? 😁 Or we split cli into cilium-cli and cilium's CLIs. |
this could be an option, i can go either way. maybe a good topic to bring up in the community meeting 💭 just as a reference cilium/cli team's responsibility is currently described as:
|
Yeah, so we at least can agree that the description doesn't match the current role of fallback for all of cilium-cli. |
The reviewer group for CLI is currently documented as having a project-wide scope: https://docs.cilium.io/en/stable/contributing/development/reviewers_committers/review_process/#project-wide . We can of course revisit this and figure out if there is a better set of individuals who could take ownership of different components. |
Document that we are planning to merge Cilium CLI code into cilium/cilium repository. Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <[email protected]>
6a7f32b
to
96314a7
Compare
#2710 should reduce the noise to the cli team during the cilium-cli release process 🚀 🙏 |
Document that we are planning to merge Cilium CLI code into cilium/cilium repository.
Ref: cilium/design-cfps#9