connectivity: test namespace suffix #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always suffix test namespace with concurrent group number. Unhide `--test-concurrency` input param. Signed-off-by: viktor-kurchenko <[email protected]>
viktor-kurchenko
force-pushed
the
pr/vk/test/ns
branch
from
f9558c7 to
fe60c11
Compare
michi-covalent
approved these changes
Jul 13, 2024
aanm
approved these changes
Jul 15, 2024
christarazi
approved these changes
Jul 15, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Aug 1, 2024
cilium/cilium-cli#2680 changed the behavior of --test-namespace flag. It's now treated as a prefix, and the namespaces always contain "-$index" suffix even if --test-concurrency is set to 1. Instead of hardcoding the namespace, use app.kubernetes.io/name label to find the test namespace. Signed-off-by: Michi Mutsuzaki <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 1, 2024
cilium/cilium-cli#2680 changed the behavior of --test-namespace flag. It's now treated as a prefix, and the namespaces always contain "-$index" suffix even if --test-concurrency is set to 1. Instead of hardcoding the namespace, use app.kubernetes.io/name label to find the test namespace. Signed-off-by: Michi Mutsuzaki <[email protected]>
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 3, 2024
[ upstream commit b189c57 ] cilium/cilium-cli#2680 changed the behavior of --test-namespace flag. It's now treated as a prefix, and the namespaces always contain "-$index" suffix even if --test-concurrency is set to 1. Instead of hardcoding the namespace, use app.kubernetes.io/name label to find the test namespace. Signed-off-by: Michi Mutsuzaki <[email protected]>
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 3, 2024
[ upstream commit b189c57 ] cilium/cilium-cli#2680 changed the behavior of --test-namespace flag. It's now treated as a prefix, and the namespaces always contain "-$index" suffix even if --test-concurrency is set to 1. Instead of hardcoding the namespace, use app.kubernetes.io/name label to find the test namespace. Signed-off-by: Michi Mutsuzaki <[email protected]> Signed-off-by: Nicolas Busseneau <[email protected]>
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 3, 2024
[ upstream commit b189c57 ] cilium/cilium-cli#2680 changed the behavior of --test-namespace flag. It's now treated as a prefix, and the namespaces always contain "-$index" suffix even if --test-concurrency is set to 1. Instead of hardcoding the namespace, use app.kubernetes.io/name label to find the test namespace. Signed-off-by: Michi Mutsuzaki <[email protected]>
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 3, 2024
[ upstream commit b189c57 ] cilium/cilium-cli#2680 changed the behavior of --test-namespace flag. It's now treated as a prefix, and the namespaces always contain "-$index" suffix even if --test-concurrency is set to 1. Instead of hardcoding the namespace, use app.kubernetes.io/name label to find the test namespace. Signed-off-by: Michi Mutsuzaki <[email protected]> Signed-off-by: Nicolas Busseneau <[email protected]>
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 5, 2024
[ upstream commit b189c57 ] cilium/cilium-cli#2680 changed the behavior of --test-namespace flag. It's now treated as a prefix, and the namespaces always contain "-$index" suffix even if --test-concurrency is set to 1. Instead of hardcoding the namespace, use app.kubernetes.io/name label to find the test namespace. Signed-off-by: Michi Mutsuzaki <[email protected]> Signed-off-by: Nicolas Busseneau <[email protected]>
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 6, 2024
[ upstream commit b189c57 ] cilium/cilium-cli#2680 changed the behavior of --test-namespace flag. It's now treated as a prefix, and the namespaces always contain "-$index" suffix even if --test-concurrency is set to 1. Instead of hardcoding the namespace, use app.kubernetes.io/name label to find the test namespace. Signed-off-by: Michi Mutsuzaki <[email protected]>
gandro
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 6, 2024
[ upstream commit b189c57 ] cilium/cilium-cli#2680 changed the behavior of --test-namespace flag. It's now treated as a prefix, and the namespaces always contain "-$index" suffix even if --test-concurrency is set to 1. Instead of hardcoding the namespace, use app.kubernetes.io/name label to find the test namespace. Signed-off-by: Michi Mutsuzaki <[email protected]> Signed-off-by: Nicolas Busseneau <[email protected]>
|
This did end up breaking our CI/CD. |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always suffix test namespace with concurrent group number.
Unhide
--test-concurrencyinput param.Thanks @asauber and @michi-covalent for the idea.
However I think these changes might be breakable for users who rely on test namespace (e.g.: in CI or other automation stuff). WDYT?