-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connectivity: Add local redirect policy tests #2568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
731a6c5
to
1d0736c
Compare
1d0736c
to
d32aa42
Compare
d32aa42
to
a3d742a
Compare
a3d742a
to
c76e70d
Compare
c76e70d
to
1a7cc8b
Compare
1a7cc8b
to
99fa7a6
Compare
99fa7a6
to
09a48ef
Compare
09a48ef
to
e1c9556
Compare
e1c9556
to
d218b6c
Compare
christarazi
reviewed
Jun 5, 2024
christarazi
approved these changes
Jun 6, 2024
Extend the features list with a flag to enable local redirect policy. Signed-off-by: Aditi Ghag <[email protected]>
Signed-off-by: Aditi Ghag <[email protected]>
It checks for a failed curl command without any network policy drops. Used in follow-up commits to validate expected result for LRP tests. The results pertain to network policy as well non network policy related checks, so move them accordingly. Signed-off-by: Aditi Ghag <[email protected]>
derailed
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aditighag Nice work!
Tests LRP connectivity scenarios with a configured skipRedirectFromBackend flag: - client pod to LRP frontend - LRP backend to LRP frontend Signed-off-by: Aditi Ghag <[email protected]>
aditighag
commented
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. @derailed Addressed the review comments.
d218b6c
to
63c6d3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces local redirect policy tests to the connectivity suite.
In order to break the circular dependency, there is a separate PR on cilium/cilium repo that enables these tests using a custom version of cilium-cli obtained from this PR changes. Here are successful test runs from the cilium/cilium PR CI runs -
Runs after addressing review comments -
https://github.com/cilium/cilium/actions/runs/9409627836/job/25920752091
https://github.com/cilium/cilium/actions/runs/9409627836/job/25919911738
https://github.com/cilium/cilium/actions/runs/9387516652/job/25850621644
https://github.com/cilium/cilium/actions/runs/9377202073/job/25819021276
https://github.com/cilium/cilium/actions/runs/9375976798/job/25815109405
https://github.com/cilium/cilium/actions/runs/9377202073/job/25818391762